Add embedding option in text editor#5948
Conversation
This reverts commit c64a1c5.
There was a problem hiding this comment.
- The new feature should still be in the dialog
- Both options should have a keyboard_arrow_down/keyboard_arrow_up icon (and the function of such)
- Both titles should have the same colour and NOT the disabled colour
- "Insert/edit link" should be changed to "Insert/edit external link"
- The option to add Home is missing right now
- The option to add more than one object is not working
- If you look at a motion with this functionality you can add a string or several motions.
- if you use this function:
- then you need to change the title to "Link a topic/motion/assignment"
- AND after you added one and then press the option again you need to add a NEW link. Right now after adding one you are visually one space behind the link, and if the option is pressed again the old link is change to the new link. Only if you are on the link (cursor directly on the last/first letter or in between) the link should be changed.
- Remove the done/clear option and if an object was selected then update the string in the selected item box directly
- The issue with the updated link if you visually are at a different place should be fixed regardless of whether or not the dialog can create one vs several links
|
We talked about this issue internally and visually want something else then described above:
|
Elblinator
left a comment
There was a problem hiding this comment.
A) The links form a topic are currently not working corretly.
Please remove any non topic from the topic selection (e.g. a motion if it's on the topic-list)
B) give the element with the class "reference" the function to open/close the menu (in cotrast to just the keyboard_arrow_up/_down
C) Disable this function for the motion editor (ANY editor which is in the motion/amendment view
D) If you navigate into the dialog with only key inputs (without the mouse) you focus a wrong element in the beginning.
After implementing B) that should again have changed, The wanted behaviour is:
- after opening the dialog
If you have both option (see C) ) - Then your focus should be on The first title/arrow and if enter is pressed then the option should open
- If you press tab then you should navigate to other title/arrow and if enter is pressed then the option should open etc.
- The next tab should navgigate to the buttons
If you have just one option (see C) )
2. The focus should be immediately on the url input field
3. Tab goes to the "Text to display" input etc.
E) If you inserted an object via your new function and decide that you want to use the other url function, then you have to close and open the dialog again and then you can insert a url. Please make a suggestion on how to prevent the needed closing of the dialog
|
About point E): The options are enabled again when another radio-button is selected. I will add a reset button again so it's more intuitive for the user. |
8cf1663 to
67f752e
Compare
Closes #5902